Bug in FloatBufferData?

[fuchs]

Ok, after having tried to update texture coordinates of a box to go along with a tiled texture for half an hour trying to figure out what I was doing wrong this time, I decided to switch tactics and blame it on Ardor3d rather than me Joking aside, I think there is a bug in FloatBufferData that affects both scaleData() and translateData().

The problem is the termination criterion of the loop:

Code: Select all

for (int i = 0; i < _buffer.remaining();) {
       _buffer.put(_buffer.get(i) * scales[i % scales.length]);
        i++;
}


Because i is incremented while remaining() decreases with every put(), you'll end up updating only the first half of the stored values, as at this point i == remaining(). The loop therefore rather must be

Code: Select all

for (int i = 0; i < _buffer.limit();) { ...}

At least this makes the texture coordinates behave as I expect after applying scaleData(). Attached a patch in case I should be right.

[renanse]

doh. Thanks. Up in svn